adapt to JetReconstruction changes making algorithm argument mandatory #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-fila
changed the title
m-fila
changed the title
m-fila
changed the title
graeme-a-stewart
approved these changes
Jul 15, 2025
Owner
graeme-a-stewart
left a comment
graeme-a-stewart
left a comment
There was a problem hiding this comment.
Thanks for the fix @m-fila
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JuliaHEP/JetReconstruction.jl#161 algorithm argument become mandatory while power become required only for generic algorithms, also some helper functions for resolving algorithm<->power mapping were removed. Some of these helper were used here, hence an updated is needed to work with current
This is not backward compatible with versions of JetReconstuction prior to JuliaHEP/JetReconstruction.jl#161.
Perhaps we could remove logging the power parameter altogether and make it backward compatible